From c3bf8117a6ecc78a8429c6f7bb7594821d47546c Mon Sep 17 00:00:00 2001 From: Ronald Schaten Date: Fri, 19 Mar 2021 14:46:48 +0100 Subject: [PATCH] refactored --- tmdb.py | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/tmdb.py b/tmdb.py index fb3a70d..9c14de8 100644 --- a/tmdb.py +++ b/tmdb.py @@ -10,16 +10,19 @@ class Tmdb: self.apikey = apikey self.language = language - def fetch_from_tmdb(self, path, parameters, data): + def fetch_from_tmdb(self, path, parameters): apikey = "?api_key=%s" % self.apikey - url = (self.baseurl + path + apikey + parameters) % data + url = self.baseurl + path + apikey + parameters json_url = urllib.urlopen(url) data = json.loads(json_url.read()) return data def get_tmdbid(self, imdbid): print("getting tmdbid for imdbid %s" % imdbid) - data = self.fetch_from_tmdb('find/%s', '&external_source=imdb_id', imdbid) + data = self.fetch_from_tmdb( + path = 'find/%s' % imdbid, + parameters = '&external_source=imdb_id' + ) try: tmdbid = data['movie_results'][0]['id'] print("tmdbid is %d" % tmdbid) @@ -30,7 +33,10 @@ class Tmdb: def get_recommendations(self, movieid, choice): print("getting %s for %d" % (choice, movieid)) - data = self.fetch_from_tmdb('movie/%d/%s', '&language=%s', (movieid, choice, self.language)) + data = self.fetch_from_tmdb( + path = 'movie/%d/%s' % (movieid, choice), + parameters = '&language=%s' % self.language + ) results = [] for result in data['results']: results.append({'title': result['title'], 'movieid': result['id']}) @@ -38,7 +44,10 @@ class Tmdb: def get_movie_trailers(self, movieid): print("getting trailers for %d" % movieid) - data = self.fetch_from_tmdb('movie/%d', '&language=%s&append_to_response=videos', (movieid, self.language)) + data = self.fetch_from_tmdb( + path = 'movie/%d' % movieid, + parameters = '&language=%s&append_to_response=videos' % self.language + ) results = [] for result in data['videos']['results']: if result['site'] == 'YouTube':